FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.3

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
78 27 0 0

Files

Class Bugs
es.upm.dit.gsi.shanks.ShanksSimulation 1
es.upm.dit.gsi.shanks.agent.JasonShanksAgent 1
es.upm.dit.gsi.shanks.agent.SimpleShanksAgent 1
es.upm.dit.gsi.shanks.agent.action.SimpleShanksAgentAction 1
es.upm.dit.gsi.shanks.agent.capability.movement.ShanksAgentMovementCapability 1
es.upm.dit.gsi.shanks.agent.capability.reasoning.bayes.smile.ShanksAgentBayesianReasoningCapability 2
es.upm.dit.gsi.shanks.agent.capability.reasoning.bayes.unbbayes.ShanksAgentBayesianReasoningCapability 1
es.upm.dit.gsi.shanks.model.ScenarioManager 4
es.upm.dit.gsi.shanks.model.element.NetworkElement 1
es.upm.dit.gsi.shanks.model.element.link.portrayal.Link2DPortrayal 1
es.upm.dit.gsi.shanks.model.event.networkelement.ProbabilisticNetworkElementEvent 2
es.upm.dit.gsi.shanks.notification.Notification 1
es.upm.dit.gsi.shanks.notification.NotificationManager 10

es.upm.dit.gsi.shanks.ShanksSimulation

Bug Category Details Line Priority
Class es.upm.dit.gsi.shanks.ShanksSimulation defines non-transient non-serializable instance field logger BAD_PRACTICE SE_BAD_FIELD Medium

es.upm.dit.gsi.shanks.agent.JasonShanksAgent

Bug Category Details Line Priority
Unchecked/unconfirmed cast from sim.engine.SimState to es.upm.dit.gsi.shanks.ShanksSimulation in es.upm.dit.gsi.shanks.agent.JasonShanksAgent.step(SimState) STYLE BC_UNCONFIRMED_CAST 132 Medium

es.upm.dit.gsi.shanks.agent.SimpleShanksAgent

Bug Category Details Line Priority
Unchecked/unconfirmed cast from sim.engine.SimState to es.upm.dit.gsi.shanks.ShanksSimulation in es.upm.dit.gsi.shanks.agent.SimpleShanksAgent.step(SimState) STYLE BC_UNCONFIRMED_CAST 58 Medium

es.upm.dit.gsi.shanks.agent.action.SimpleShanksAgentAction

Bug Category Details Line Priority
Unread public/protected field: es.upm.dit.gsi.shanks.agent.action.SimpleShanksAgentAction.affected STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 39 Medium

es.upm.dit.gsi.shanks.agent.capability.movement.ShanksAgentMovementCapability

Bug Category Details Line Priority
Test for floating point equality in es.upm.dit.gsi.shanks.agent.capability.movement.ShanksAgentMovementCapability.normalizeDouble3D(Double3D) STYLE FE_FLOATING_POINT_EQUALITY 180 High

es.upm.dit.gsi.shanks.agent.capability.reasoning.bayes.smile.ShanksAgentBayesianReasoningCapability

Bug Category Details Line Priority
Primitive value is boxed then unboxed to perform primitive coercion in es.upm.dit.gsi.shanks.agent.capability.reasoning.bayes.smile.ShanksAgentBayesianReasoningCapability.updateSoftEvidenceAuxiliaryNodeCPT(Network, String, HashMap) PERFORMANCE BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION 232 Medium
es.upm.dit.gsi.shanks.agent.capability.reasoning.bayes.smile.ShanksAgentBayesianReasoningCapability.addEvidence(Network, String, String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 97 Medium

es.upm.dit.gsi.shanks.agent.capability.reasoning.bayes.unbbayes.ShanksAgentBayesianReasoningCapability

Bug Category Details Line Priority
Primitive value is boxed then unboxed to perform primitive coercion in es.upm.dit.gsi.shanks.agent.capability.reasoning.bayes.unbbayes.ShanksAgentBayesianReasoningCapability.updateSoftEvidenceAuxiliaryNodeCPT(ProbabilisticNetwork, String, HashMap) PERFORMANCE BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION 248 Medium

es.upm.dit.gsi.shanks.model.ScenarioManager

Bug Category Details Line Priority
Unchecked/unconfirmed cast from sim.engine.SimState to es.upm.dit.gsi.shanks.ShanksSimulation in es.upm.dit.gsi.shanks.model.ScenarioManager.step(SimState) STYLE BC_UNCONFIRMED_CAST 86 Medium
Class es.upm.dit.gsi.shanks.model.ScenarioManager defines non-transient non-serializable instance field logger BAD_PRACTICE SE_BAD_FIELD Medium
Class es.upm.dit.gsi.shanks.model.ScenarioManager defines non-transient non-serializable instance field portrayal BAD_PRACTICE SE_BAD_FIELD Medium
Class es.upm.dit.gsi.shanks.model.ScenarioManager defines non-transient non-serializable instance field scenario BAD_PRACTICE SE_BAD_FIELD Medium

es.upm.dit.gsi.shanks.model.element.NetworkElement

Bug Category Details Line Priority
Unwritten field: es.upm.dit.gsi.shanks.model.element.NetworkElement.universal CORRECTNESS UWF_UNWRITTEN_FIELD 296 Medium

es.upm.dit.gsi.shanks.model.element.link.portrayal.Link2DPortrayal

Bug Category Details Line Priority
Unchecked/unconfirmed cast from sim.portrayal.DrawInfo2D to sim.portrayal.network.EdgeDrawInfo2D in es.upm.dit.gsi.shanks.model.element.link.portrayal.Link2DPortrayal.draw(Object, Graphics2D, DrawInfo2D) STYLE BC_UNCONFIRMED_CAST 16 Medium

es.upm.dit.gsi.shanks.model.event.networkelement.ProbabilisticNetworkElementEvent

Bug Category Details Line Priority
es.upm.dit.gsi.shanks.model.event.networkelement.ProbabilisticNetworkElementEvent.addPossibleAffectedElement(Class, HashMap) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 91 Medium
es.upm.dit.gsi.shanks.model.event.networkelement.ProbabilisticNetworkElementEvent.addPossibleAffectedScenario(Class, HashMap) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 44 Medium

es.upm.dit.gsi.shanks.notification.Notification

Bug Category Details Line Priority
Unwritten field: es.upm.dit.gsi.shanks.notification.Notification.target CORRECTNESS UWF_UNWRITTEN_FIELD 86 Medium

es.upm.dit.gsi.shanks.notification.NotificationManager

Bug Category Details Line Priority
Write to static field es.upm.dit.gsi.shanks.notification.NotificationManager.ID_COUNTER from instance method new es.upm.dit.gsi.shanks.notification.NotificationManager(ShanksSimulation) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 84 High
Write to static field es.upm.dit.gsi.shanks.notification.NotificationManager.logger from instance method new es.upm.dit.gsi.shanks.notification.NotificationManager(ShanksSimulation) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 80 High
Write to static field es.upm.dit.gsi.shanks.notification.NotificationManager.notifables from instance method new es.upm.dit.gsi.shanks.notification.NotificationManager(ShanksSimulation) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 82 High
Write to static field es.upm.dit.gsi.shanks.notification.NotificationManager.notifications from instance method new es.upm.dit.gsi.shanks.notification.NotificationManager(ShanksSimulation) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 81 High
Write to static field es.upm.dit.gsi.shanks.notification.NotificationManager.sim from instance method new es.upm.dit.gsi.shanks.notification.NotificationManager(ShanksSimulation) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 83 High
Write to static field es.upm.dit.gsi.shanks.notification.NotificationManager.logger from instance method new es.upm.dit.gsi.shanks.notification.NotificationManager(List, List, ShanksSimulation, Logger) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 60 High
Write to static field es.upm.dit.gsi.shanks.notification.NotificationManager.notifables from instance method new es.upm.dit.gsi.shanks.notification.NotificationManager(List, List, ShanksSimulation, Logger) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 62 High
Write to static field es.upm.dit.gsi.shanks.notification.NotificationManager.notifications from instance method new es.upm.dit.gsi.shanks.notification.NotificationManager(List, List, ShanksSimulation, Logger) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 61 High
Write to static field es.upm.dit.gsi.shanks.notification.NotificationManager.sim from instance method new es.upm.dit.gsi.shanks.notification.NotificationManager(List, List, ShanksSimulation, Logger) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 63 High
Write to static field es.upm.dit.gsi.shanks.notification.NotificationManager.ID_COUNTER from instance method new es.upm.dit.gsi.shanks.notification.NotificationManager(List, List, ShanksSimulation, Logger) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 64 Medium